[explorer] feat: Added account remark table.#2223
Open
AnthonyLaw wants to merge 6 commits into
Open
Conversation
AnthonyLaw
force-pushed
the
explorer/add-remark-table
branch
from
057a853 to
227b5b2
Compare
AnthonyLaw
force-pushed
the
explorer/add-remark-table
branch
from
227b5b2 to
52f0bf0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2223 +/- ##
=======================================
Coverage 96.94% 96.95%
=======================================
Files 267 267
Lines 19638 19649 +11
Branches 215 215
=======================================
+ Hits 19039 19050 +11
Misses 593 593
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Wayonb
requested changes
May 28, 2026
| ''' | ||
| CREATE TABLE IF NOT EXISTS account_remarks ( | ||
| address bytea PRIMARY KEY, | ||
| remarks varchar NOT NULL |
| ''' | ||
| INSERT INTO account_remarks ( | ||
| address, | ||
| remarks |
Contributor
There was a problem hiding this comment.
remarks => remark
below also
| cosignatory_of, | ||
| cosignatories | ||
| cosignatories, | ||
| remarks |
| 'cosignatoryOf': self.cosignatory_of, | ||
| 'cosignatories': self.cosignatories | ||
| 'cosignatories': self.cosignatories, | ||
| 'remarks': self.remarks |
| # Create Account remarks table | ||
| cursor.execute( | ||
| ''' | ||
| CREATE TABLE IF NOT EXISTS account_remarks ( |
Contributor
There was a problem hiding this comment.
account_remarks => account_remark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Missing account remarks table.
Solution:
--account-remarksflag to allow flexible updates or adding more account information.remarksinformation.