fix(vllm_apertus_1.5): align Dockerfile ENTRYPOINT with upstream vLLM image#158
fix(vllm_apertus_1.5): align Dockerfile ENTRYPOINT with upstream vLLM image#158subnet-dev wants to merge 1 commit into
Conversation
|
|
I notice that the other images don't have a clean entrepont configured either. It would be nice to have all the images with a correctly configured entrepont. What do you think? |
AryanAhadinia
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution. The usage of the docker images in this repo is for preparing the environment for SLURM jobs, and then, the SLURM will run the job shell script on top of the specified docker image. As a result, we are afraid that specifying entry point for the docker image results in failure of SLURM to run the shell script. I checked this with Claude and it also mentioned that the failure is possible. It would be great if you could make sure that the SLURM jobs with this docker image are working fine before merging the PR in.



Motivation
The
vllm_apertus_1.5image is intended to run the vLLM OpenAI-compatible server, but it previously defined noENTRYPOINT(orCMD). Without this, users must know and manually type thevllm servecommand on everydocker run, which is error-prone and breaks parity with the officialvllm/vllm-openaiimage.Change
Add the standard vLLM instruction at the end of the Dockerfile:
This aligns vllm_apertus_1.5 with the vllm-project/vllm (https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile) Dockerfile, where the vllm-openai target uses the same ENTRYPOINT.