Skip to content

fix(vllm_apertus_1.5): align Dockerfile ENTRYPOINT with upstream vLLM image#158

Open
subnet-dev wants to merge 1 commit into
mainfrom
fix/vllm-apertus-1.5-align-entrypoint
Open

fix(vllm_apertus_1.5): align Dockerfile ENTRYPOINT with upstream vLLM image#158
subnet-dev wants to merge 1 commit into
mainfrom
fix/vllm-apertus-1.5-align-entrypoint

Conversation

@subnet-dev

Copy link
Copy Markdown
Contributor

Motivation

The vllm_apertus_1.5 image is intended to run the vLLM OpenAI-compatible server, but it previously defined no ENTRYPOINT (or CMD). Without this, users must know and manually type the vllm serve command on every docker run, which is error-prone and breaks parity with the official vllm/vllm-openai image.

Change

Add the standard vLLM instruction at the end of the Dockerfile:

ENTRYPOINT ["vllm", "serve"]

This aligns vllm_apertus_1.5 with the vllm-project/vllm (https://github.com/vllm-project/vllm/blob/main/docker/Dockerfile) Dockerfile, where the vllm-openai target uses the same ENTRYPOINT.

@sonarqubecloud

Copy link
Copy Markdown

@subnet-dev

Copy link
Copy Markdown
Contributor Author

I notice that the other images don't have a clean entrepont configured either. It would be nice to have all the images with a correctly configured entrepont. What do you think?

@AryanAhadinia AryanAhadinia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution. The usage of the docker images in this repo is for preparing the environment for SLURM jobs, and then, the SLURM will run the job shell script on top of the specified docker image. As a result, we are afraid that specifying entry point for the docker image results in failure of SLURM to run the shell script. I checked this with Claude and it also mentioned that the failure is possible. It would be great if you could make sure that the SLURM jobs with this docker image are working fine before merging the PR in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants