Aptos: Add to liquidswap pool (WIP) by nicomiicro · Pull Request #451 · swim-io/swim

nicomiicro · 2022-10-20T04:25:24Z

Notion ticket: https://www.notion.so/exsphere/Aptos-integration-f6daa06ac05b48f490528c38a50ffd88

Creates a fake USDC in Aptos and a liquidswap pool with this USDC and our attested swimUSD
Updates UI config
Fixed a bug on token balance query method

Checklist

Github project and label have been assigned
Tests have been added or are unnecessary
Docs have been updated or are unnecessary
Preview deployment works (visit the Cloudflare preview URL)
Manual testing in #product-testing completed or unnecessary
New i18n strings do not contain any security vulnerabilities (e.g. should not allow translator to update email/url)
When fetching new translations from external sources, do a sanity check (e.g. get people who speak the language to check, shove all new translations into Google translate)

cloudflare-workers-and-pages · 2022-10-20T04:33:48Z

Deploying with Cloudflare Pages

Latest commit:	`c706d96`
Status:	✅ Deploy successful!
Preview URL:	https://9549dba7.swim-ui.pages.dev
Branch Preview URL:	https://aptos-contracts-2tlh.swim-ui.pages.dev

View logs

nicomiicro · 2022-10-20T10:05:56Z

I'm unsure on how to update src/core/selectors/swapTokenOptions.test.ts. Why do we have a different way to "disable" pools in there?

wormat

Cool!

wormat · 2022-10-20T10:17:21Z

+      displayName: "Aptos USDC",
+      isStakingPool: false,
+      isStableSwap: true, // TODO is it?
+      isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?


We'll be removing this property from the SDK. Can you expand on the question here though?

I was wondering if a boolean is enough now that we introduce another pool type, since we filter with this in a few different places, but I guess I will figure out soon.

The SDK won't have any legacy support, so this is purely a UI question. I don't have the full context so can't give an opinion beyond that.

oh so this flag is going to be removed then?

From the SDK, yes. We'll be adding it to the UI pool type.

See https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8

wormat · 2022-10-20T14:21:28Z

+      displayName: "Aptos USDC",
+      isStakingPool: false,
+      isStableSwap: true, // TODO is it?
+      isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?


From the SDK, yes. We'll be adding it to the UI pool type.

wormat · 2022-10-20T14:21:47Z

+      displayName: "Aptos USDC",
+      isStakingPool: false,
+      isStableSwap: true, // TODO is it?
+      isLegacyPool: false, // TODO, not legacy, not evm though, do we need a type here?


See https://www.notion.so/exsphere/Remove-any-kind-of-legacy-support-from-the-SDK-e2bb36ec76164d2e98de8a270296e9d8

nicomiicro · 2022-10-20T15:16:47Z

@wormat I'll need your help with the publishing of the two packages 🙏

Aptos: update wormhole and lp addresses

Aptos: add to pool (WIP)

without pool math and gas estimation...

Co-authored-by: Will <86618292+wormat@users.noreply.github.com>

Aptos: Add to pool (basic - no pool math, no gas estimation)

nicomiicro added the feature New feature or request label Oct 20, 2022

nicomiicro self-assigned this Oct 20, 2022

nicomiicro requested a review from wormat October 20, 2022 04:26

wormat reviewed Oct 20, 2022

View reviewed changes

nicomiicro force-pushed the aptos/contracts branch from 90533ca to 7eaf992 Compare October 20, 2022 12:58

swim-io deleted a comment from wormat Oct 20, 2022

nicomiicro added 13 commits October 20, 2022 16:13

feat(aptos-contracts): Create testnet pool

a567f0e

chore(token-projects): Add TokenProjectId.SwimAptosUsdcLp

e10a0ae

chore(aptos): Add tokens and pools details

3fb7e7d

wip: revert publish package

c985a41

chore(ui): update aptos tokens and pools config

2b27e2c

fix(aptos): handle zero balance on getTokenBalance

cfec682

fix(aptos): use correct pool address

d295098

chore(aptos-contracts): add a note for the initial minted coins amount

9736f22

docs(aptos-contracts): add prompt symbol to all commands

1fcec0f

docs(aptos-contracts): link to attestation app

ffa0002

docs(attestation): clarify format of APTOS_ACCOUNT_PRIVATE_KEY

c0c09d8

chore(aptos-contracts): use a diff version

0a0affd

docs(aptos-contracts): grammar mistake

991a573

nicomiicro force-pushed the aptos/contracts branch from b4aea42 to 991a573 Compare October 20, 2022 13:13

nicomiicro added 2 commits October 20, 2022 16:44

Merge branch 'master' into aptos/contracts

c59b8eb

test(ui): update swapTokenOptions snapshot

fb10b42

wormat reviewed Oct 20, 2022

View reviewed changes

refactor(attestation): handle hex prefix in Aptos account private key

333c481

nicomiicro requested a review from wormat October 20, 2022 14:33

wormat previously approved these changes Oct 20, 2022

View reviewed changes

feat(core): Add PoolState interface to core

343fa35

nicomiicro added 5 commits October 21, 2022 16:07

feat(core): Add getPoolState to client interface

a4d8dae

feat(aptos): implement client.getPoolState

cf1e61d

feat(ui): add aptos pool state queries

bcb6fcd

fix(aptos): use proper resource type in getTokenBalance

634b35e

Merge branch 'master' into aptos/contracts

006370b

nicomiicro dismissed wormat’s stale review via 006370b October 25, 2022 09:22

nicomiicro and others added 17 commits October 25, 2022 12:49

Merge branch 'aptos/contracts' into aptos/add-to-pool

eedbc49

chore(aptos): update contracts addresses

6619a0f

Merge pull request #462 from swim-io/aptos/update-wormhole-and-lp

c7a38c6

Aptos: update wormhole and lp addresses

refactor(ui): define local AptosPoolState

dfcba14

refactor(aptos): remove AptosPoolState

cdf1422

refactor(aptos): tidy up utils and types

8b3c262

test(ui): update swapTokenOptions.test.ts.snap

eb5f30b

Merge branch 'aptos/contracts' into aptos/add-to-pool

9d0af66

refactor(aptos): rename const to constants

4f3fd60

refactor(aptos): rename getBalances to getPoolBalances

c7156f1

Merge pull request #460 from swim-io/aptos/add-to-pool

823318a

Aptos: add to pool (WIP)

fix(ui): remove duplicate ecosystem array

9ed167c

fix(aptos): remove buggy liquidswap SDK

d3a923a

feat(aptos): Add getAddLiquidityTransactionPayload

f1d424b

feat(ui): Add to Aptos pool

4ea4f74

without pool math and gas estimation...

chore(aptos): fix typo

ca3a003

Co-authored-by: Will <86618292+wormat@users.noreply.github.com>

Merge pull request #468 from swim-io/aptos/add-to-pool-2

c706d96

Aptos: Add to pool (basic - no pool math, no gas estimation)

nicomiicro changed the title ~~Aptos: pool contract and UI config~~ Aptos: Add to liquidswap pool (WIP) Oct 26, 2022

nicomiicro marked this pull request as draft October 26, 2022 19:08

Conversation

nicomiicro commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

cloudflare-workers-and-pages Bot commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying with Cloudflare Pages

Uh oh!

nicomiicro commented Oct 20, 2022

Uh oh!

wormat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicomiicro commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nicomiicro commented Oct 20, 2022 •

edited

Loading

cloudflare-workers-and-pages Bot commented Oct 20, 2022 •

edited

Loading