Add StreamingBehavior to AsyncBufferSequence for throughput/latency control#228
Open
dannys42 wants to merge 3 commits intoswiftlang:mainfrom
Open
Add StreamingBehavior to AsyncBufferSequence for throughput/latency control#228dannys42 wants to merge 3 commits intoswiftlang:mainfrom
dannys42 wants to merge 3 commits intoswiftlang:mainfrom
Conversation
Contributor
|
Hi @dannys42, thanks for the PR! I do like the idea of
|
Author
|
Thanks @iCharlesHu! I can try to take a look at Linux, but I don't really have a way of testing Windows.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When streaming subprocess output, users previously had no control over the trade-off between throughput and latency. The sequence always batched data for maximum throughput, which limits use for interactive cases where users want to receive output as soon as it's available.
Changes
AsyncBufferSequence.StreamingBehaviorenum with three modes:.throughput(default): batch data for best performance (preserves the existing behavior).balanced: batch data with guaranteed 250ms max delivery interval.latency: deliver data as soon as it's available (also bounded by 250ms)streamingBehaviorparameter to allrunoverloads that expose anAsyncBufferSequence, defaulting to.throughputfor backwards compatibility.latencyand.balancedbehaviors