[android] Skip source fetch during android build-docker#538
[android] Skip source fetch during android build-docker#538justice-adams-apple wants to merge 4 commits intomainfrom
Conversation
finagolfin
left a comment
There was a problem hiding this comment.
If this is working in your testing, looks good to me.
|
@shahmishal, can @justice-adams-apple or somebody else you trust be made a code owner on this Android SDK directory alone in this repo as part of this pull, so we can make Android changes more quickly? I want to whittle these Android scripts down to just downloading the NDK, running a It would be better if I could do that as a series of smaller pulls that Justice or somebody else can review in the coming months, rather than waiting for you to review all that, as I'm sure you're very busy. Once all that is in, all future config would be done in those toolchain repos instead, and changes here would be minimal. |
Yes, #539 |
|
Thanks, Justice, I hope I didn't sign you up for a bunch more CI work you don't want, 😉 though at least with my Android pulls, I will ask other Android workgroup members like @marcprux, who put together a significant portion of these CI scripts with me, to review also. |
|
@justice-adams-apple, more Android CI work required to get this in? I'd like to rebase #536 on this and get that in next. |
This should allow us to rework our CI job for PR testing to use build-docker