Fixed draw selection to be better overall#209
Open
ReverM wants to merge 1 commit intoswaroopg92:masterfrom
Open
Fixed draw selection to be better overall#209ReverM wants to merge 1 commit intoswaroopg92:masterfrom
ReverM wants to merge 1 commit intoswaroopg92:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely redid the draw_selection method to be less complex, and better with irregular grids.
This uses fancy linear algebra to find the vertices of the inner selection shape. There is an improvement to be made regarding actually projecting to a vector perpendicular to the side, but this only affects the penrose tiling at the moment so I believe it is passable. Please let me know if the look of draw_selection for penrose is too odd.