This repository was archived by the owner on Sep 14, 2022. It is now read-only.
Correct content-length generation for JSON#176
Open
kcsham wants to merge 1 commit intoswagger-api:masterfrom
Open
Correct content-length generation for JSON#176kcsham wants to merge 1 commit intoswagger-api:masterfrom
kcsham wants to merge 1 commit intoswagger-api:masterfrom
Conversation
Use correct HttpEntity to report Content-Length.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use correct HttpEntity to report Content-Length.
The problem became substantial when the swagger.json is accessed through an API gateway (e.g. AWS load balancer) where proper content-length header is required to properly close the connection.
Without this fix, the following warning is shown on the Play console when the swagger json is requested.
[WARN] [05/24/2018 18:03:09.086] [play-dev-mode-akka.actor.default-dispatcher-2] [akka.actor.ActorSystemImpl(play-dev-mode)] Explicitly set HTTP header 'Content-Length: 11163' is ignored, explicitContent-Lengthheader is not allowed. Use the appropriate HttpEntity subtype.