Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
LGTM — the React key fix and trailing-comma cleanup are correct for the stated scope of this PR.
Extended reasoning...
Overview
Two files changed: PageAside/index.tsx adds index to the map callback and uses a composite key (toc-item-${heading.id}-${index}) to eliminate the duplicate-key React warning; vercel.ts adds a trailing comma after the last headers entry.
Security risks
No security-sensitive code is touched. No credentials, secrets, or auth logic involved.
Level of scrutiny
Both changes are mechanical and low-risk. The key change is the standard React pattern for lists that may contain non-unique IDs. The trailing comma is purely cosmetic/style.
Other factors
The inline bug comment flags a pre-existing issue (stateless slug() producing duplicate heading IDs in src/lib/markdown.ts), but that defect predates this PR and is not introduced or worsened here. The PR title accurately describes its scope: fixing the duplicate key error. The root-cause fix for duplicate anchor targets is a separate follow-up concern already captured in the inline comment.
No description provided.