Add favicon#5
Open
BravishkaSkytano wants to merge 1 commit into
Open
Conversation
BravishkaSkytano
marked this pull request as ready for review
November 19, 2020 02:19
Owner
|
Apologies for the 2-year delay. This would limit the favicon to be .png, wouldn't it? I think it would be better to not have this, as all browsers default to favicon.ico. If the user needs something else, he'd add a custom line like this. Open for feedback. |
Author
|
It's been a while since I used this theme, however, I do recall trying to use a favicon.ico and it didn't work. You could set it as a config variable instead, I suppose. favicon: /assets/favicon.ico |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every site should have a favicon. Users will only need to add one file to the site's root directory.