fix(ui): clarify GitHub on-push path filter copy#4861
Closed
shiroyasha wants to merge 1 commit into
Closed
Conversation
Rename the paths field copy so it reads as a changed-file path filter, drop GitHub Actions wording, add example placeholders, and wire list item inputs to use the field definition placeholder. Co-authored-by: Igor Šarčević <igisar@gmail.com>
|
👋 Commands for maintainers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4860.
Summary
github.onPush): Renamed the optional paths section to Changed path filter, rewrote the description so it clearly refers to filtering pushes by added, modified, and removed file paths, removed GitHub Actions wording from the in-app description and trigger documentation, and set an example placeholder for each path pattern row.ListFieldRenderernow passes the field definitionplaceholderthrough to each primitive list rowInput, so list-backed settings can show placeholders (not only this trigger).Verification
go test ./pkg/integrations/github/components/contents/...web_srcproduction build was not run locally (generated@/api-clientabsent in this environment); CI /make check.build.uiaftermake dev.setupshould validate the UI bundle.