chore: add unit tests for ListIntegrations and ListInvitations - #4856
Conversation
|
👋 Commands for maintainers:
|
Signed-off-by: Krishna <krishnakumar2811004@gmail.com>
81731ec to
3fb426f
Compare
|
Friendly follow-up on this PR. Please let me know if there are any concerns or changes needed from my side. Thanks for taking a look. |
|
Hey @krishna28004, sorry for the late late response, we had quite a few open pull-requests. |
|
Risk: 8/100 (very low) SummaryAdds a new test file with four unit tests for the ListIntegrations action covering empty list, single, multiple, and cross-org isolation cases; no production code is changed. Concerns
Recommended reviewers: lucaspin |
|
/sem-approve |
Signed-off-by: Igor Šarčević <igor@operately.com>
|
/sem-approve |
|
Congrats on your first merged pull-requests @krishna28004! Thanks for contributing to SuperPlane. |
|
Thank you! @shiroyasha, I appreciate the review and support. Looking forward to contributing more. |
…planehq#4856) Signed-off-by: Krishna <krishnakumar2811004@gmail.com> Signed-off-by: Igor Šarčević <igor@operately.com> Co-authored-by: Igor Šarčević <igisar@gmail.com> Co-authored-by: Igor Šarčević <igor@operately.com>
Description
This PR adds unit test coverage for the
ListIntegrationsandListInvitationsgRPC endpoints.Coverage Included
Notes
The tests were written following existing repository conventions (
support.Setup(t), deterministic assertions, and organization boundary validation patterns).I validated formatting and repository conventions locally. Full local execution currently requires generated protobuf artifacts (
pkg/protos/*) and compose-based setup workflows that are not yet configured in my environment, so CI will perform the final execution pass.