update SidePanel layout #3401
Open
update SidePanel layout #3401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 31e448a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sirineJ
force-pushed
the
side-panel-layout
branch
from
ffed9df to
96854db
Compare
Contributor
|
Size Change: -182 B (-0.02%) Total Size: 752 kB
ℹ️ View Unchanged
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
==========================================
- Coverage 93.91% 93.91% -0.01%
==========================================
Files 195 195
Lines 4406 4402 -4
Branches 1708 1702 -6
==========================================
- Hits 4138 4134 -4
Misses 243 243
Partials 25 25
🚀 New features to boost your workflow:
|
sirineJ
force-pushed
the
side-panel-layout
branch
from
96854db to
e14b775
Compare
sirineJ
force-pushed
the
side-panel-layout
branch
from
e14b775 to
5bb94bd
Compare
sirineJ
force-pushed
the
side-panel-layout
branch
from
5bb94bd to
e073b0a
Compare
sirineJ
force-pushed
the
side-panel-layout
branch
from
e073b0a to
704eb2e
Compare
sirineJ
force-pushed
the
side-panel-layout
branch
from
704eb2e to
db657b1
Compare
Contributor
🚀 Your packages were publishedPublished Packages:
|
sirineJ
force-pushed
the
side-panel-layout
branch
from
db657b1 to
31e448a
Compare
connor-baer
reviewed
Dec 30, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@sumup-oss/circuit-ui": minor | |||
Member
There was a problem hiding this comment.
This is a breaking change as it significantly impacts the page layout.
Member
There was a problem hiding this comment.
And I'd consider the removal of the isPrimaryContentResized property a breaking change as well.
| }, | ||
| "packages/circuit-ui/node_modules/@sumup-oss/design-tokens": { | ||
| "version": "9.0.0", | ||
| "resolved": "https://pkg.pr.new/sumup-oss/circuit-ui/@sumup-oss/design-tokens@96854db", |
|
|
||
| .headline { | ||
| flex: 1 1 auto; | ||
| margin-left: var(--cui-spacings-zetta); |
Member
There was a problem hiding this comment.
The left margin on the header was to ensure that it isn't overlapped by the close button.
| display: flex; | ||
| align-items: center; | ||
| width: 100%; | ||
| height: var(--cui-spacings-zetta); |
Member
There was a problem hiding this comment.
What if the headline inside the header wraps to multiple lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses DSYS-1440
Purpose
To support the new navigation styles, the current behavior of the SidePanel component needs to be updated.
Update the positioning and styling of the SidePanel so that it slides in over the existing page content rather than pushing adjacent content. When opened, the SidePanel should overlay the underlying content and no longer affect or disrupt the page layout.
Approach and changes
--cui-z-index-side-paneltoken to make SidePanels appear above navigation components.Definition of done