Skip to content

Conversation

@suketa
Copy link
Owner

@suketa suketa commented Dec 26, 2025

Summary by CodeRabbit

  • Chores

    • Updated CI workflows to use DuckDB 1.4.3 across macOS, Windows, and Ubuntu.
  • Tests

    • Adjusted test behavior to skip a config test for DuckDB versions through 1.4.3.
  • Documentation

    • Added an Unreleased changelog entry noting the DuckDB bump.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

📝 Walkthrough

Walkthrough

This PR bumps DuckDB from 1.4.2 to 1.4.3 in the CI test matrices for macOS, Ubuntu, and Windows, adds an Unreleased changelog entry, and extends a test skip condition to include DuckDB 1.4.3.

Changes

Cohort / File(s) Summary
CI Workflow Version Updates
\.github/workflows/test_on_macos.yml, \.github/workflows/test_on_ubuntu.yml, \.github/workflows/test_on_windows.yml
Updated matrix entry duckdb from 1.4.21.4.3; no other steps or control flow changes.
Changelog Documentation
CHANGELOG.md
Added Unreleased entry: "bump duckdb to 1.4.3 on CI."
Tests — Skip Condition Extended
test/duckdb_test/database_test.rb
Broadened skip condition in test_s_open_with_config to also skip for DuckDB 1.4.3 (previously up to 1.4.2).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

Possibly related PRs

Poem

🐰 I hopped through CI with a springy plea,

"Bump DuckDB up to one point four dot three!"
Workflows updated, changelog sings,
Tests skip where needed — a rabbit flings,
🥕🌿— a tiny hop for harmony.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'bump duckdb 1.4.3' directly summarizes the main change: updating DuckDB version to 1.4.3 across CI workflows and tests.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch duckdb_1.4.3

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd0fd54 and 837bb76.

📒 Files selected for processing (1)
  • test/duckdb_test/database_test.rb
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: suketa
Repo: suketa/ruby-duckdb PR: 0
File: :0-0
Timestamp: 2025-01-24T22:18:24.630Z
Learning: When using ruby-asan (AddressSanitizer), avoid letting DuckDB throw C++ exceptions by checking conditions (like table existence) beforehand and raising Ruby exceptions directly to prevent ASAN from intercepting the C++ exceptions.
📚 Learning: 2025-01-24T22:18:24.630Z
Learnt from: suketa
Repo: suketa/ruby-duckdb PR: 0
File: :0-0
Timestamp: 2025-01-24T22:18:24.630Z
Learning: When using ruby-asan (AddressSanitizer), avoid letting DuckDB throw C++ exceptions by checking conditions (like table existence) beforehand and raising Ruby exceptions directly to prevent ASAN from intercepting the C++ exceptions.

Applied to files:

  • test/duckdb_test/database_test.rb
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: test (3.3.10, 1.3.2)
  • GitHub Check: test (3.2.9, 1.3.2)
  • GitHub Check: test (3.4.8, 1.4.3)
  • GitHub Check: test (3.3.10, 1.4.3)
  • GitHub Check: test (3.2.9, 1.3.2)
  • GitHub Check: test (mingw, 1.4.3)
  • GitHub Check: test (3.2.9, 1.4.3)
  • GitHub Check: test (3.4.8, 1.3.2)
  • GitHub Check: test (mingw, 1.3.2)
🔇 Additional comments (1)
test/duckdb_test/database_test.rb (1)

42-42: Add a comment explaining why DuckDB 1.4.0-1.4.3 config test must be skipped.

The change correctly extends the skip condition to version 1.4.3, consistent with the existing pattern for versions 1.4.0, 1.4.1, and 1.4.2. However, there is no documentation in the codebase explaining the reason for skipping these consecutive versions. Add a comment referencing the specific DuckDB issue or behavior that requires the skip:

# Skip config test for DuckDB 1.4.0-1.4.3 due to [issue/reason]
skip 'config test' if %w[1.4.0 1.4.1 1.4.2 1.4.3].include?(library_version.to_s)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@suketa suketa merged commit 3d122f0 into main Dec 27, 2025
38 checks passed
@suketa suketa deleted the duckdb_1.4.3 branch December 27, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants