Keep class based components and add function component version in detail.#374
Open
0xprincedev wants to merge 2 commits intosudheerj:masterfrom
Conversation
Contributor
Author
|
I updated after reading your feedback about keeping class based components and add function component version in detail. class Greeting extends React.Component {
render() {
return <div>Hello {this.props.message}</div>;
}
}
ReactDOM.render(
<Greeting message="World" />,
document.getElementById("root")
);Functional component versionconst Greeting = ({ message }) => {
return <div>Hello {message}</div>;
};
ReactDOM.render(
<Greeting message="World" />,
document.getElementById("root")
);You can write the same code without JSX as below, class Greeting extends React.Component {
render() {
return React.createElement("div", null, `Hello ${this.props.message}`);
}
}
ReactDOM.render(
React.createElement(Greeting, { message: "World" }, null),
document.getElementById("root")
);Functional component versionconst Greeting = ({ message }) => {
return React.createElement("div", null, `Hello ${message}`);
};
ReactDOM.render(
React.createElement(Greeting, { message: "World" }, null),
document.getElementById("root")
); |
Contributor
Author
|
Could you please review this PR? @sudheerj |
Owner
|
@0xprincedev Those are legacy questions. That's why I used the same class component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated class based components to functional components for question 83:
Is it possible to use react without JSX?