Skip to content

refactor(extensions): introduce argument matcher - #245

Draft
benbellick wants to merge 3 commits into
mainfrom
refactor/argument-matcher
Draft

refactor(extensions): introduce argument matcher#245
benbellick wants to merge 3 commits into
mainfrom
refactor/argument-matcher

Conversation

@benbellick

Copy link
Copy Markdown
Member

Function variant matching currently spreads argument position resolution, nullability handling, variadic expansion, and constrained any validation across several helpers. This refactors those responsibilities behind an internal matcher so the matching flow has one place to evolve without changing the exported matching APIs.

This is intended to be behavior-preserving groundwork for improving constrained any matching semantics in a follow-up PR.


Note: This PR was developed with AI assistance. All changes have been reviewed, and I take full responsibility for this contribution.

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.28%. Comparing base (0ae704f) to head (36fb338).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
extensions/variants.go 93.61% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   68.85%   69.28%   +0.43%     
==========================================
  Files          47       47              
  Lines       10866    10980     +114     
==========================================
+ Hits         7482     7608     +126     
+ Misses       3030     3009      -21     
- Partials      354      363       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant