Conversation
|
|
|
Hi @gkiely. Thanks a lot for this PR! We would really appreciate if you could continue your work here 💯 |
|
Seems like the only failures are prettier-related? |
|
may I help with the PR? |
|
Hi! Thanks for submitting, we'll watch the tagged issue! |
|
Any reason why stripe cannot just use URLSearchParams ? |
|
CI seems to be failing |
|
Is this still happening? Removing qs would be great! |
|
Yes, this would be amazing. qs adds an extra 18 (!) packages through transitive dependencies which is crazy for something that should be so simple |
|
Hi @gkiely! Checking in to see if you still plan on continuing this work |
|
@mbroshi-stripe would it be best to update the stringify function to add support for My main concern in adding a custom stringify/parse function is if later more functionality is needed. |
|
Thanks for the PR and all the feedback. Closing this in favor of #2168 |
Based off this comment
#2038 (comment)
Includes a lightweight alternative to qs.stringify that can run in worker environments.
I have added 80% of the tests from the qs library, if you think this is a good approach I can add the remainder. I wanted to confirm it is viable before I put any more time into it :)