Support for StripeAccount in StripeClient, and StripeContext on V1#1952
Merged
jar-stripe merged 2 commits intosdk-release/next-majorfrom Mar 13, 2025
Merged
Conversation
removed v1 limitation on using StripeContext added tests
jar-stripe
requested review from
prathmesh-stripe
and removed request for
a team
prathmesh-stripe
approved these changes
Mar 10, 2025
Contributor
|
One test is failing. Otherwise LGTM |
Contributor
Author
|
compat error is expected, because we are adding a new abstract method to a public class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The SDK should support setting StripeAccount and StripeContext at the client level, and StripeClient should be accepted in the same way across V1 and V2 APIs.
What?
See Also
Changelog
getStripeAccounttoStripeResponseGetterOptions. If you have a class that extendsStripeResponseGetterOptionsyou will need to implement this method.setStripeAccountto StripeClientBuilder, so you can specify the Stripe-Account header at the client (instead of the individual request) level.