Skip to content

ci: run test job on ubuntu + windows matrix, fix Playwright setup for Windows#184

Merged
JReinhold merged 3 commits intocopilot/windows-copilot-setup-probefrom
copilot/sub-pr-183
Mar 3, 2026
Merged

ci: run test job on ubuntu + windows matrix, fix Playwright setup for Windows#184
JReinhold merged 3 commits intocopilot/windows-copilot-setup-probefrom
copilot/sub-pr-183

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

Completes the CI follow-up from the Windows probe PR: adds Windows to the test matrix, makes the Playwright install OS-aware, and restores the Copilot setup workflow to Ubuntu.

Changes

  • check.ymltest job matrix: Only the test job now runs on both ubuntu-latest and windows-latest (fail-fast: false). All other jobs remain Ubuntu-only.
  • Codecov uploads gated to Ubuntu: Both coverage and test-result uploads have if: matrix.os == 'ubuntu-latest' to avoid duplicate uploads and OIDC failures on Windows.
  • setup-playwright/action.yml – OS-aware install: --with-deps (Linux system package installs) is skipped on Windows; both OSes still use --only-shell.
    if [ "$RUNNER_OS" = "Linux" ]; then
      pnpm exec playwright install --with-deps --only-shell
    else
      pnpm exec playwright install --only-shell
    fi
  • copilot-setup-steps.yml: Reverted runs-on from windows-latest back to ubuntu-latest.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2026

⚠️ No Changeset found

Latest commit: bff4d63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ert copilot setup to ubuntu

Co-authored-by: JReinhold <5678122+JReinhold@users.noreply.github.com>
Copilot AI changed the title [WIP] Update CI workflow for Windows runner in Copilot setup ci: run test job on ubuntu + windows matrix, fix Playwright setup for Windows Mar 3, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 3, 2026

npm i https://pkg.pr.new/storybookjs/mcp/@storybook/addon-mcp@184
npm i https://pkg.pr.new/storybookjs/mcp/@storybook/mcp@184

commit: 0db4cfe

@codecov
Copy link

codecov bot commented Mar 3, 2026

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
436 1 435 0
View the full list of 1 ❄️ flaky test(s)
apps/internal-storybook/tests/check-deps.e2e.test.ts > Storybook Dependencies > should be using latest versions from registry

Flake rate in main: 27.42% (Passed 45 times, Failed 17 times)

Stack Traces | 5.63s run time
Error: Storybook dependencies are outdated. Update the catalog in pnpm-workspace.yaml:

  sed -i '' 's/10\.3\.0-alpha\.12/10.3.0-alpha.13/g' pnpm-workspace.yaml && pnpm install

Outdated packages:
  - @storybook/addon-docs: 10.3.0-alpha.12 → 10.3.0-alpha.13
  - @storybook/react-vite: 10.3.0-alpha.12 → 10.3.0-alpha.13
  - storybook: 10.3.0-alpha.12 → 10.3.0-alpha.13
 ❯ tests/check-deps.e2e.test.ts:42:10

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Handle CRLF checkouts on Windows runners before applying the catalog regex so Playwright version resolution succeeds.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@JReinhold JReinhold marked this pull request as ready for review March 3, 2026 12:41
@JReinhold JReinhold merged commit cc74c76 into copilot/windows-copilot-setup-probe Mar 3, 2026
@JReinhold JReinhold deleted the copilot/sub-pr-183 branch March 3, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants