fix: try to improve error handling logic in unixfs streams#1261
Open
fix: try to improve error handling logic in unixfs streams#1261
Conversation
right now errors in the `finalize` methods can leave a writer unclosed forever - this should help improve the DX issues described in storacha/console#81 (comment) by at least printing an error to the console with information about the problem
alanshaw
requested changes
Jan 18, 2024
confirmed this results in better behavior in the web console! was also able to test the error path here - I tried to create a `File` that represents a directory like in runtime error but could not reproduce - that seems to be a weird edge case that is hard to reproduce outside the browser context
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now errors in the
finalizemethods can leave a writer unclosed forever - this should help improve the DX issues described in storacha/console#81 (comment) by at least printing an error to the console with information about the problem