Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR alters the dealer
aggregate/offerandaggregate/acceptinvocation caveats such that they take an optional "group" string, which is passed on to Spade.The aggregator already has the concept of grouping for aggregates. It ensures data from different storefronts is segregated. i.e. it segregates forge aggregates from hot network aggregates. After an aggregate has been created it is submitted to the delaer, whose job it is to get the data into a filecoin deal. The group information is lost here.
Now, in this PR, the group is passed to the dealer. The idea is that the dealer passes this grouping information to Spade in the (currently unused)
Collectionparameter. It'll allow Spade to query the correct network to find the node(s) the blob is stored on, so that Spade can obtain a delegation for reading the content that can be passed on to the Filecoin SP.refs storacha/spade#15
refs storacha/spade#16