Skip to content

chore: more error context#302

Merged
alanshaw merged 2 commits intomainfrom
ash/chore/moar-err-context
Apr 14, 2026
Merged

chore: more error context#302
alanshaw merged 2 commits intomainfrom
ash/chore/moar-err-context

Conversation

@alanshaw
Copy link
Copy Markdown
Member

Finding it really hard to track down an error because we're just returning the error without wrapping it in a lot of cases.

@alanshaw alanshaw requested review from Peeja and frrist April 10, 2026 14:15
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/service/service.go 20.00% 8 Missing ⚠️
pkg/providerresults/providerresults.go 40.00% 2 Missing and 1 partial ⚠️
pkg/service/providerindex/providerindex.go 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
pkg/redis/noproviderstore.go 84.61% <100.00%> (+2.79%) ⬆️
pkg/service/providerindex/providerindex.go 68.04% <0.00%> (ø)
pkg/providerresults/providerresults.go 78.37% <40.00%> (-3.98%) ⬇️
pkg/service/service.go 81.59% <20.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes an issue where the non-AWS indexing service no-provider cache
tramples over the keys to the regular provider cache due to the redis
instance being shared.
@alanshaw alanshaw merged commit 06ad0a3 into main Apr 14, 2026
12 of 13 checks passed
@alanshaw alanshaw deleted the ash/chore/moar-err-context branch April 14, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants