Adding proxy to tests for QE environment

[dbuchanaRH]

Summary by CodeRabbit

• Tests
  • Updated test HTTP client setups to honor proxy settings from the environment, improving test reliability and execution in environments that require HTTP proxy configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1af329fa-4e12-4bac-a937-28e3c6051629

📥 Commits

Reviewing files that changed from the base of the PR and between e392476 and 9ed27f1.

📒 Files selected for processing (4)

• tests/pkg/tests/observability_alert_test.go
• tests/pkg/tests/observability_route_test.go
• tests/pkg/utils/mco_dashboard.go
• tests/pkg/utils/mco_metric.go

🚧 Files skipped from review as they are similar to previous changes (2)

• tests/pkg/utils/mco_dashboard.go
• tests/pkg/utils/mco_metric.go

---

📝 Walkthrough

Walkthrough

Four test and utility files were updated to set Proxy: http.ProxyFromEnvironment on their http.Transport instances so HTTP clients used in observability tests and dashboard/metric utilities honor environment proxy settings; TLS and auth behavior remain unchanged. (43 words)

Changes

Cohort / File(s)	Summary
Observability tests tests/pkg/tests/observability_alert_test.go, tests/pkg/tests/observability_route_test.go	Added Proxy: http.ProxyFromEnvironment to http.Transport used by test http.Clients for alertmanager and metrics/alert route tests; TLS RootCAs retained.
MCO utilities (dashboard & metrics) tests/pkg/utils/mco_dashboard.go, tests/pkg/utils/mco_metric.go	Set Proxy: http.ProxyFromEnvironment on non-KIND HTTP transports in Grafana/dashboard and metrics query paths; existing TLS InsecureSkipVerify/token logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🧭 Clients now heed the proxy sign,
Routes and dashboards fall in line.
A small tweak in each transport’s core,
Network traffic finds the door.
Secure and tidy — ship it, score! 🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding proxy configuration to HTTP clients across multiple test files for QE environment compatibility.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dbuchanaRH]

/cherry-pick release-2.16 release-2.15 release-2.14

[openshift-cherrypick-robot]

@dbuchanaRH: once the present PR merges, I will cherry-pick it on top of release-2.16 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.16 release-2.15 release-2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jacobbaungard]

/lgtm

[jacobbaungard]

/cherry-pick release-2.17

[openshift-cherrypick-robot]

@jacobbaungard: once the present PR merges, I will cherry-pick it on top of release-2.17 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jacobbaungard]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dbuchanaRH, jacobbaungard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jacobbaungard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobbaungard]

/test test-e2e

[dbuchanaRH]

/test e2e-kind

[openshift-cherrypick-robot]

@dbuchanaRH: new pull request created: #2423

Details

In response to this:

/cherry-pick release-2.16 release-2.15 release-2.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@jacobbaungard: new pull request created: #2424

Details

In response to this:

/cherry-pick release-2.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.