[release-2.14] [ACM-25688] Add bucket name length validation to prevent S3/GCS deployment failures#2254
Conversation
- Validate S3/GCS bucket names (3-63 chars) in s3_conf.go and gcs_conf.go - Add webhook admission validation to reject invalid CRs early - Add comprehensive unit tests for bucket name validation - Provide clear error messages when bucket names exceed limits Fixes late-stage thanos-store pod crashes due to long auto-generated bucket names from ObjectBucketClaim on clusters with long domain names. Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This is an automated cherry-pick of #2238
/assign coleenquadros