refactor: Add ability to hydrate outside batch() - #186
Open
Dadadah wants to merge 1 commit into
Open
Conversation
Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Dadadah
force-pushed
the
refactor/hydrateoutsidebatch
branch
from
August 10, 2026 02:23
2ac7bd0 to
0d509d3
Compare
amycatgirl
approved these changes
Aug 10, 2026
| * Hydrate a new user if it is not in the collection yet. This function does | ||
| * not add the user to the store, make sure you call | ||
| * UserCollection.addHydratedUser afterwards. This function is particularly | ||
| * useful when adding many users asynchronously. See Server.syncMembers for |
Member
There was a problem hiding this comment.
Nit: JSDoc supports linking to the file the object/class and property is in using the @link{} tag
https://jsdoc.app/tags-inline-link
https://jsdoc.app/about-namepaths
Member
Author
There was a problem hiding this comment.
nice I didn't know that. I'll update this then merge it later today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By hydrating outside of the batch() solidjs call we save approximately 30% on large server list syncs.