Treesitter support for Elm#511
Open
tasuki wants to merge 2 commits intostevearc:masterfrom
Open
Conversation
tasuki
force-pushed
the
ts-support-for-elm
branch
from
6c18273 to
45aed4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, if I knew it was this easy I'd have done it years ago!
Unfortunately I can't run the tests... ok I spent the ten minutes to installtree-sittercli, get a newnvim, and fix the tests. Would you like me to also add a PR with requirements/instructions for running tests locally? I feel the UX could be improved a little. (I'm rather impressed by your thorough CI on GitHub side: great job!)I also tested manually that it's working. Here's a screenshot, left side is Elm with LSP (what I suffered with), right is TS (yay, indentation!):
(Disclaimer: I did use a LLM in the creation of this PR, but take full responsibility for any mistakes and full credit if it works 😉)