Skip to content

more scrollbar issues#3

Open
jaycfields wants to merge 2 commits into
stephenbez:masterfrom
jaycfields:master
Open

more scrollbar issues#3
jaycfields wants to merge 2 commits into
stephenbez:masterfrom
jaycfields:master

Conversation

@jaycfields
Copy link
Copy Markdown
Contributor

So, I spent the better part of a morning tweaking a few things and found two issues:

  • if you don't set the parent of the tilava table to position absolute, things can go very wrong
  • since the 'newWidth' can shrink & grow dynamically, the margin for the parent needs to shrink & grow dynamically as well. Since $table.parent().parent() is a container not created or controlled by tilava, it seems like it might make sense to double wrap (so you control the container) or look at another solution. I just used $table.parent().parent() to demonstrate a solution, not the one that I expect you'll want to use eventually.

If you don't do both of those things, the scroll bar can be cut off on the left, can show up way too far to the left (if the table is wide enough that it causes h-scrolling, or can be a bit too far to the right.

To reproduce, you can go to http://stephenbez.github.com/tilava-table/example.html and ctrl+mouse wheel. (for the cut off and slightly too right versions. I can send over the way too far left also, if you want)

@jaycfields
Copy link
Copy Markdown
Contributor Author

sorry, you can reproduce the other issue as well at http://stephenbez.github.com/tilava-table/example.html

go there and ctrl+mouse wheel up all until you're zoomed in all the way.
right click & inspect element, and add "width:100%" to the "tilava-table-wrapper" and check out where the scroll bar is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant