Skip to content

Conversation

@dmkozh
Copy link
Contributor

@dmkozh dmkozh commented Jan 28, 2026

Also removed mentions of CAP-72 from most sections, as it seems like it's unlikely that we'll do CAP-72.

Without CAP-72 there is not much motivation to provide granular control control over trustline limits from Soroban or checking if a trustline exists in the first place. Thus just one simple function for creating trustlines when necessary is introduced instead of 2 functions we had before.

Also removed mentions of CAP-72 from most sections, as it seems like it's unlikely that we'll do CAP-72.

Without CAP-72 there is not much motivation to provide granular control control over trustline limits from Soroban or checking if a trustline exists in the first place. Thus just one simple function for creating trustlines when necessary is introduced instead of 2 functions we had before.
Copilot AI review requested due to automatic review settings January 28, 2026 01:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CAP-0073 to simplify the Soroban interface for managing classic trustlines, focusing on a single allow_trust function and de-emphasizing CAP-72. It also clarifies how XLM SAC transfers create accounts and updates the design rationale accordingly.

Changes:

  • Replace the previous change_trust and has_trust SAC functions with a single allow_trust(env: Env, address: Address) function that creates an unlimited trustline if it is missing.
  • Clarify semantics for allow_trust, including no-op behavior for C-addresses, required authorization only on trustline creation, and use of i64::MAX as the trustline limit.
  • Remove most references to CAP-72 and adjust the XLM transfer and design rationale sections to match the new, simplified trustline-creation behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dmkozh and others added 3 commits January 28, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant