[CAP-79] Rename muxed address strkey conversion functions #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's per CAP discussion feedback
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the proposed muxed address strkey conversion host functions in CAP-0079 to use clearer, non-versioned names, reflecting CAP discussion feedback.
Changes:
- Update the Abstract to reference
strkey_to_muxed_addressandmuxed_address_to_strkeyinstead of the previous*_v2names. - Rename the corresponding host function entries in the JSON specification from
strkey_to_address_v2/address_to_strkey_v2tostrkey_to_muxed_address/muxed_address_to_strkey. - Update the semantics section headings and descriptions to use the new function names while keeping the behavior description unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leighmcculloch
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's per CAP discussion feedback