Skip to content

SEP-41: add mint and clawback event#1588

Merged
dmkozh merged 9 commits intostellar:masterfrom
chowbao:sep-41-add-mint-event
Mar 13, 2025
Merged

SEP-41: add mint and clawback event#1588
dmkozh merged 9 commits intostellar:masterfrom
chowbao:sep-41-add-mint-event

Conversation

@chowbao
Copy link
Contributor

@chowbao chowbao commented Dec 12, 2024

Discussion

Add a mint and clawback event to SEP-41 to be able to track balances through events correctly

This does not define a mint() nor clawback() function. This only defines the events themselves to be SEP-41 compliant

@chowbao chowbao changed the title add mint event to sep-41 add mint and clawback event to sep-41 Jan 8, 2025
@leighmcculloch leighmcculloch changed the title add mint and clawback event to sep-41 SEP-41: add mint and clawback event Jan 15, 2025
sisuresh
sisuresh previously approved these changes Jan 15, 2025
leighmcculloch
leighmcculloch previously approved these changes Jan 16, 2025
Copy link
Member

@leighmcculloch leighmcculloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't think we should merge it until CAP-67 is further along, just because once this is merged there's a cost to iterating on it that doesn't exist if we iterate on it in this PR.

@ozgunozerk
Copy link
Contributor

I think this is a great step. As someone who is new to the ecosystem, I think there might be a confusion around this new change though. There is mint event specified, but no mention of mint() function. Quoting from @chowbao's comment on the relevant discussion:

This SEP has purposely not added an mint() nor init_asset() function to give contracts more flexibility. The theory is that a contract should be free to define how they want to mint a new custom token. There doesn't need to be an standard single initialization function. There are existing contracts that have an initialize() function that does emit the mint event. By not adding a minting function to the interface, these existing contracts with be compliant with this SEP without changes.

This explanation is currently implicit, but if made explicit by putting it in SEP-41, I think a lot of confusion will be prevented, and people will better understand the design rationale behind this.

P.S. needless the say, the same goes for clawback event and clawback() function.

@github-actions
Copy link

This pull request is stale because it has been open for 30 days with no activity. It will be closed in 30 days unless the stale label is removed.

@chowbao chowbao dismissed stale reviews from leighmcculloch and sisuresh via 4c6427b March 13, 2025 17:37
@dmkozh dmkozh merged commit 1e09d9f into stellar:master Mar 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants