Conversation
dmkozh
reviewed
Dec 11, 2024
Contributor
dmkozh
left a comment
dmkozh
left a comment
There was a problem hiding this comment.
I haven't looked through the full CAP yet (and the semantics probably can be discussed separately), but I have some issues with the XDR that probably are easier to resolve now.
tamirms
reviewed
Dec 11, 2024
tamirms
reviewed
Dec 11, 2024
tamirms
reviewed
Dec 11, 2024
tamirms
reviewed
Dec 12, 2024
dmkozh
reviewed
Dec 12, 2024
anupsdf
reviewed
Dec 17, 2024
anupsdf
reviewed
Dec 18, 2024
anupsdf
reviewed
Dec 19, 2024
anupsdf
reviewed
Dec 19, 2024
anupsdf
reviewed
Dec 20, 2024
anupsdf
reviewed
Dec 20, 2024
anupsdf
reviewed
Dec 20, 2024
anupsdf
reviewed
Dec 20, 2024
anupsdf
reviewed
Dec 20, 2024
Contributor
|
CAP needs to be renumbered. Please avoid discussions in PRs and prefer discussions to make it easier to retroactively understand points that were debated |
Contributor
Author
|
Addressed some of the comments, but let's merge this and move this over to discussion per Nico. |
dmkozh
previously approved these changes
Jan 14, 2025
dmkozh
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial draft CAP for in-memory Soroban state and automatic entry restoration via
InvokeHostFunctionOp. It depends on partial state archival from CAP-0062, but not full state archival of CAP-0057.