Open
Conversation
Extend wallet metadata & API with selected account persistence and normalization for legacy activeAccounts
Update WalletProvider to expose/select current account and persist selections
Replace first-account assumptions in portfolio and signer flows with selected account
Implement wallet selector UI and integrate into splitted layout
Update import and create wallet hooks to use optional password to match new API props
Componentize create/import flows and create non-onboarding cases
Use previously componentized flows for create/import wallet onboarding flows
Add create/import wallet routes for non-onboarding flows. Enables wallet setup outside of the initial onboarding flow
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: d23b4f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Jenkins BuildsClick to see older builds (6)
|
Collaborator
Nice work, the testing guide worked well. Can we have multiple accounts in a wallet like MetaMask? |
jinhojang6
reviewed
Apr 14, 2026
jinhojang6
reviewed
Apr 14, 2026
jinhojang6
reviewed
Apr 14, 2026
jinhojang6
reviewed
Apr 14, 2026
jinhojang6
reviewed
Apr 14, 2026
jkbktl
reviewed
Apr 14, 2026
Collaborator
|
Was the final design decision discussed with design team? Why wasn't sidebar used in the end? |
Comment current account's name tooltip displayed on address hover. Since multi-account support is not implemented yet, this feature is more confusing than helpful.
Replace all use of currently selected account name by currently selected wallet name. The purpose is to avoid any confusion in the UI/UX between accounts and wallets.
Since we don't have multi-account support right now, rename to wallet-selector to make it explicist and avoid any confusion.
There was no point in having `wallet-flow` as an existing route, it was a mistake.
invalidateQueries will already handle the refetch for active queries.
Legacy wallets stored with the default name "Account 1" are now automatically renamed to the next available "Wallet N" during normalization. The rename is persisted to the store so it only runs once per legacy wallet.
Contributor
Author
Here are all the latest changes: https://github.com/status-im/status-web/pull/1097/changes/05dadc2a4cb4de106ede249c7a570f169d3df7b1..a1cfea77f70fae6ba683fcb25c1eb845d22e184c 
|
Contributor
Author
|
JulesFiliot
commented
Apr 16, 2026
Contributor
Author
There was a problem hiding this comment.
Move to packages/wallet/components/?
jinhojang6
approved these changes
Apr 16, 2026
Collaborator
jinhojang6
left a comment
jinhojang6
left a comment
There was a problem hiding this comment.
LGTM. The only UX feedback I have is that we could use a different icon for each wallet, like metamask does. Currently all wallets use the same icon (emoji?).
github-project-automation
bot
moved this from In Progress
to Waiting
in Web & User Interfaces
Contributor
Author
Yes good point, I think we can circle back to the emoji/icon question when implementing the multi-account feature. Because when implementing the multi-account feature the design might look too dense with icons for wallets & accounts (not sure what the UI/UX will be though). By the way, I believe Metamask only shows icons for accounts, not wallets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
WalletAccountSelectordropdown in portfolio header for switching wallets and accessing create/import flows/wallet-flow/newand/wallet-flow/importroutes - reuse onboarding flow components but skip password creation (prompt existing password via modal instead)CreateWalletFlow,ImportWalletFlow,CreatePasswordStep,BackButton,OnboardingFlowLayout)activeAccountsrenamed toaccounts, addedselectedAccountAddressfield;normalizeWallet()handles legacy compatibilitywallet.add/wallet.importAPI:nameandpasswordnow optional when vault exists; names auto-increment (Wallet 1,Wallet 2, etc.)currentAccountderived from selected wallet; selected wallet ID persisted to local storage/wallet-flow/*redirects to/onboardingwhen no wallets existTo test:
activeAccountsfield, verify they load and normalize correctly (basically you can switch between them, etc.)/onboarding/new-> set password -> lands on portfolio/onboarding/import-> enter phrase & password -> lands on portfolio/wallet-flow/newwith no wallets -> redirects to/onboarding;/onboardingwith wallets -> redirects to portfolioScreenshots
WalletAccountSelector: