Remove empty directories on Clean Generated Files with Blobs#6749
Remove empty directories on Clean Generated Files with Blobs#6749SandiyosDev wants to merge 2 commits intostashapp:developfrom
Conversation
SandiyosDev
changed the title
|
So I see 7 PR's opened by you recently. I see that they are also somewhat small but lets keep it down to a few PRs at a time and not start flooding stuff. You don't need to close anything existing but lets stop on anymore till your others can be verified. |
|
Cool, I'm only doing 3-4 a day on my free time, I'll work on other repos for now |
Gykes
left a comment
Gykes
left a comment
There was a problem hiding this comment.
Concept is good. Since you added that function you can add it to CleanThumbnail and CleanMarkers
|
@Gykes Does my last commit seem good with you? |
Gykes
left a comment
Gykes
left a comment
There was a problem hiding this comment.
Static review looks good
Was able to build and run clean, no obvious errors appeared.
My dev env doesn't have to much to clean up but the logic seems sound.
Would this repo entertain me building a devcontainer similar to what Immich uses? |
|
0 experience with that. Perhaps create an issue or ask in discord for opinions. |
2 participants
close #5354
already triaged, blob files gets cleaned but empty hash prefix folders stick around, added a pass after walk to remove them
respects dry-run