Skip to content

fix screenshot generation for .webm with sparse keyframe#6747

Open
SandiyosDev wants to merge 1 commit intostashapp:developfrom
Bridgebox-dev:fix/6499-webm-screenshot-seek
Open

fix screenshot generation for .webm with sparse keyframe#6747
SandiyosDev wants to merge 1 commit intostashapp:developfrom
Bridgebox-dev:fix/6499-webm-screenshot-seek

Conversation

@SandiyosDev
Copy link
Copy Markdown
Contributor

title

close #6499

ref
2026-03-24-131949_2560x1440_scrot

Copy link
Copy Markdown
Collaborator

@Gykes Gykes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No testing was done on this but won't this slow down cover/sprite/phash generation? We might be better off going some kind of try/catch situation where we try to do it the fast way, if it fails due to being to short, go the slower way.

@feederbox826
Copy link
Copy Markdown
Member

Can you add phash parity testing before and after this change? If we can't ensure parity between this and previous versions then we have no choice but to reject

@SandiyosDev
Copy link
Copy Markdown
Contributor Author

how about we try fast seek first and fall back to accurate seek on failure, I can add a ScreenshotTimeAccurate func and fallback at each call site
its the same idea as the existing SlowSeek pattern in the sprite generator

@feederbox826
Copy link
Copy Markdown
Member

if parity tests fail theres no point

@SandiyosDev
Copy link
Copy Markdown
Contributor Author

if I implement a fallback, it'll only trigger when fast seek fails entirely, so theres no parity chagne for files that already worked, they still use fast seek and get the same frame. only files that were previously erroring out would get a frame via accurate seek

@feederbox826
Copy link
Copy Markdown
Member

then a parity test should be no issue at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error generating phash/sprites/screenshot for short videos

3 participants