Skip to content

Adds show favorites first for performers, studios, tags#6733

Open
floyd352 wants to merge 1 commit intostashapp:developfrom
floyd352:feature/favorites-first-sorting
Open

Adds show favorites first for performers, studios, tags#6733
floyd352 wants to merge 1 commit intostashapp:developfrom
floyd352:feature/favorites-first-sorting

Conversation

@floyd352
Copy link
Copy Markdown

This feature adds the ability to favorite performers, studios, tags, which makes them always appear first.

CleanShot 2026-03-22 at 10 42 55

The request from @feederbox826 specifies tags but I went ahead and allowed for anything that can be favorited. I figure we might as well allow it all.

These changes also apply to all the tabs pages like: Tags -> Performers tab, Tags -> Studio tab, Studios -> Performers tab.

Closes #5785

Note

A number of the changes in here, like the Go code, are AI generated. I've reviewed the code changes personally to the best of my ability. I have manually tested it.

Tags

CleanShot 2026-03-22 at 10 44 29

Performers (favorited, number of gallery ASC)

CleanShot 2026-03-22 at 10 44 58

Performers (favorited, random DESC)

CleanShot 2026-03-22 at 11 11 19

Studios -> Performers tab (favorited, name DESC)

CleanShot 2026-03-22 at 11 11 59

@feederbox826
Copy link
Copy Markdown
Member

Deferring for now - Actually a request I forwarded from the discord.

Bones look to be okay but theres a few quirks with ratings? that warrant a closer look

@feederbox826 feederbox826 added the deferred Good feature that can be looked at for a later release. label Mar 22, 2026
@Gykes
Copy link
Copy Markdown
Collaborator

Gykes commented Mar 22, 2026

I haven't done research or looked at the code just my initial thoughts.

Would it be better to just automatically have favorited content just go to the top? I'm not sure if I'm misremembering but I feel like quite a few apps just automatically do it. The settings page is already a cluster and putting more in there would just make it even worse.

Just looking for opinions

@floyd352
Copy link
Copy Markdown
Author

floyd352 commented Mar 23, 2026

theres a few quirks with ratings? that warrant a closer look

@feederbox826 Thanks for checking it out, can you share a bit more information to make it easier to reproduce

Would it be better to just automatically have favorited content just go to the top?

@Gykes there's a comment in the issue of "Should be optional", I originally agreed with it.
It's a good question, we have ratings and we have favorites on the same items. You can technically give 1 star to a favorited item which is a bit odd. One difference is that you can't sort by favorites, as far as I can tell. So even if you mark an item as favorite, if you can't sort, there's no easy way to find it in the library?
I like the idea of making this feature optional, but if you can't sort by favorite, I'm kind of lost what is the difference/point of favorite is compared to rating. At the time of writing this, I think either we should be able to sort by favorite, or maybe it favorite does behave differently and bring to the top.

EDIT: I'll wait for responses before suggesting something that might result in scope creep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deferred Good feature that can be looked at for a later release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Display favourite tags first

3 participants