Skip to content

central_systest_blobs: sort hashsets when dumping#13865

Open
dorimedini-starkware wants to merge 1 commit into04-23-central_systest_blobs_first_commit_of_crate_basic_two-tx_blob_datafrom
04-24-central_systest_blobs_sort_hashsets_when_dumping
Open

central_systest_blobs: sort hashsets when dumping#13865
dorimedini-starkware wants to merge 1 commit into04-23-central_systest_blobs_first_commit_of_crate_basic_two-tx_blob_datafrom
04-24-central_systest_blobs_sort_hashsets_when_dumping

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented Apr 24, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 24, 2026

PR Summary

Low Risk
Low risk: changes are limited to dev-dependencies and test serialization output normalization to reduce nondeterministic ordering in golden files.

Overview
Makes central_systest_blobs regression outputs deterministic by normalizing JSON dumps (sorting specific HashSet-backed array fields before pretty-printing) so golden-file comparisons don’t flake due to iteration order.

Adds serde as a dev-dependency (and updates Cargo.lock) to support the new serde::Serialize-based normalization helper used by the tests.

Reviewed by Cursor Bugbot for commit c7cf0bd. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 04-24-central_systest_blobs_sort_hashsets_when_dumping branch from 1510d08 to c7cf0bd Compare April 25, 2026 10:22
@dorimedini-starkware dorimedini-starkware force-pushed the 04-23-central_systest_blobs_first_commit_of_crate_basic_two-tx_blob_data branch from 4fa8da7 to 7adb70d Compare April 25, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants