fix: unexpected INFO message when create an Account without Paymaster#1605
Open
PhilippeR26 wants to merge 1 commit intostarknet-io:developfrom
Open
fix: unexpected INFO message when create an Account without Paymaster#1605PhilippeR26 wants to merge 1 commit intostarknet-io:developfrom
PhilippeR26 wants to merge 1 commit intostarknet-io:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
When creating an
Accountinstance with :(so, without paymaster option)
We have this log:
In fact, the Account constructor is calling
new PaymasterRpc()if no paymaster option. It generates this INFO message about default paymaster urlUsage related changes
None
Development related changes
mute?: booleanoption, that is used by the constructor ofAccount, to avoid the info message.PaymasterRpcOptions, thedefaultoption is removed (useless).Checklist: