SNIP-36 - helper for creation of signed transaction#1603
Open
PhilippeR26 wants to merge 5 commits intostarknet-io:developfrom
Open
SNIP-36 - helper for creation of signed transaction#1603PhilippeR26 wants to merge 5 commits intostarknet-io:developfrom
PhilippeR26 wants to merge 5 commits intostarknet-io:developfrom
Conversation
Member
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
In the frame of SNIP-36, proof are generated by an off-line sequencer backend. A
RPC.INVOKE_TXN_V3signed transaction has to be sent to this backend.Today,
Account.executeis generating thisRPC.INVOKE_TXN_V3internally and send it to the node, but we don't have a method to provide these data to users.This PR is adding a such method.
Usage related changes
Account.getSignedTransaction()method. Parameters are 100% the same thanAccount.execute(). Example:Then
tx3can be sent to the backend, to generate the proof.RpcProvider.invokeSignedTx(). This method is not necessary in the frame of SNIP-36, but it's consistent to have in Starknet.js both a method to create a signed Tx and a method to consume it. Example:Development related changes
As 90% of code of
Account.execute()is common withAccount.getSignedTransaction(), this common part has been written is a newprepareInvoke()function.Checklist: