Improve Test Descriptions for Enum and Tuple Validation Errors#1396
Open
kilavvy wants to merge 4 commits intostarknet-io:developfrom
Open
Improve Test Descriptions for Enum and Tuple Validation Errors#1396kilavvy wants to merge 4 commits intostarknet-io:developfrom
kilavvy wants to merge 4 commits intostarknet-io:developfrom
Conversation
Author
1 similar comment
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request updates the descriptions of two test cases to improve clarity and consistency. Specifically:
requestParser.test.ts, the test description for handling errors with inactive variants in custom enums has been clarified.validate.test.ts, the test description for tuple validation errors has been made more explicit.No changes to the test logic were made; only the test case descriptions were updated for better readability and understanding.