Fix model load for unsupported models by pyvene#146
Open
Masao-Taketani wants to merge 1 commit intostanfordnlp:mainfrom
Open
Fix model load for unsupported models by pyvene#146Masao-Taketani wants to merge 1 commit intostanfordnlp:mainfrom
Masao-Taketani wants to merge 1 commit intostanfordnlp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There exists a problem when you load a model which is unsupported by pyvene (issues such as #126 and #86).
So, I created one static method for
ReftModelnamedload_pv_undefined_modelin order to save the models I mentioned above.I also add the description of the function in README.md.
Please review the modification and if I could help you any further, please let me know.
Thank you!