Step size and gradient clipping for bias terms#209
Open
ErinGeorge wants to merge 1 commit intostanfordnlp:masterfrom
Open
Step size and gradient clipping for bias terms#209ErinGeorge wants to merge 1 commit intostanfordnlp:masterfrom
ErinGeorge wants to merge 1 commit intostanfordnlp:masterfrom
Conversation
Adds gradient clipping and step size for bias update terms.
Contributor
|
What's kind of weird about this is that by missing the eta term in the original bias calculation, we've effectively made the learning rate for the bias 200x the default learning rate for the rest of the parameters. Our first couple experiments with this on rebuilding English word vectors w/ and w/o this change make it appear that the new learning rate is making the results worse. We'll dig into it some more and check if there's a way to scale eta for the bias in such a way that the vectors are coming out better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added processing on the updates for the bias terms of the word vectors to mirror the other updates. Without these, the
etaandgrad-clipparameters do not function as described, and the loss function minimized is not quite the one that appears in the original paper.In personal experiments, this does not seem to affect the final output of the code noticeably in most cases. It appears to only matter in certain edge cases where the original code fails to converge, such as when the co-occurence matrix contains many entries between 0 and 1.0.