[DO NOT MERGE] User renderer for everything - #77
Draft
aparlato wants to merge 11 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites the repo to use the renderer for everything rather than try to convert to SVG.
This should significantly reduce future bugs and maintenance needs. A tradeoff is that it's a bit slower to load (needs to render a map with each layer and convert to png, but we do keep these so they only have to be loaded once per style/property combo).
@ebrelsford @kelsey-taylor @almccon would you all take a look and let me know what you think of this direction?
Changes to debate
Data conditions
Instead of our previous naive handling of conditionals by attempting to show all outputs from a
caseormatchexpression, this has converted to setting data with any properties and values found in the style. Users can update the data to what they want to see.This makes it harder to compare, but functionally far more solid. My inclination is to continue with this approach and discuss ways we can accommodate it to our comparison needs since the previous approach both breaks our ability to use the renderer exclusively and does not cleanly fit all cases, sometimes causing bugs.
Fills and lines
Previously we showed line color and opacity in the fills page as well as the fills. This is technically inaccurate so I divided the pages more cleanly by type.
If this is necessary, it's an easy fix, but we should reconsider our page naming.