Porridge/push upstream operator

[porridge]

Description

change me!

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• added unit tests
• added e2e tests
• added regression tests
• added compatibility tests
• modified existing tests

How I validated my change

change me!

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[sourcery-ai]

Hey - I've left some high level feedback:

• In operator/tests/run.sh, consider quoting the operator_cluster_type in the conditional (e.g. [[ "$operator_cluster_type" == "openshift4" ]]) and explicitly handling unexpected/empty values so the deployment path is clearer and less error-prone.
• In .github/workflows/build.yaml, all uses of ${QUAY_ORG} assume it is set by earlier steps; it might be safer to set a default or add an explicit check/fail-fast if QUAY_ORG is unset to avoid pushing to an unintended registry when the matrix or labels change.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In operator/tests/run.sh, consider quoting the operator_cluster_type in the conditional (e.g. [[ "$operator_cluster_type" == "openshift4" ]]) and explicitly handling unexpected/empty values so the deployment path is clearer and less error-prone.
- In .github/workflows/build.yaml, all uses of ${QUAY_ORG} assume it is set by earlier steps; it might be safer to set a default or add an explicit check/fail-fast if QUAY_ORG is unset to avoid pushing to an unintended registry when the matrix or labels change.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhacs-bot]

Images are ready for the commit at d492ca9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-755-gd492ca9b76.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.92%. Comparing base (0041570) to head (d492ca9).
⚠️ Report is 11 commits behind head on master.

Files with missing lines	Patch %	Lines
operator/internal/common/status/controller.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #18454      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files        2631     2629       -2     
  Lines      197964   197814     -150     
==========================================
- Hits        96872    96788      -84     
+ Misses      93703    93640      -63     
+ Partials     7389     7386       -3     

Flag	Coverage Δ
go-unit-tests	48.92% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.