Address post-approval review feedback on VirtualMCPServer authz#5368
Merged
Conversation
Follow-ups from the post-approval review of #5290, bundled because they touch overlapping files: * Distinguish `AuthzConfigMapInvalid` from `AuthzConfigMapNotFound` on `MCPRemoteProxy`, restoring status condition parity with `VirtualMCPServer`. * Gate the `AuthzPrimaryUpstreamProviderDeprecated` warning event on a generation transition so it fires once per spec change. * Align the authz config `version` field on `"1.0"` via a shared constant; the inline path previously diverged with `"v1"`. * Narrow the misleading `ExtractCedarAuthzOptions` doc comment.
blkt
requested review from
ChrisJBurns,
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5368 +/- ##
==========================================
- Coverage 68.72% 68.71% -0.02%
==========================================
Files 625 625
Lines 63422 63412 -10
==========================================
- Hits 43587 43573 -14
- Misses 16585 16595 +10
+ Partials 3250 3244 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the post-approval review of #5290, bundled because they touch overlapping files:
AuthzConfigMapInvalidfromAuthzConfigMapNotFoundonMCPRemoteProxy, restoring status condition parity withVirtualMCPServer.AuthzPrimaryUpstreamProviderDeprecatedwarning event on a generation transition so it fires once per spec change.versionfield on"1.0"via a shared constant; the inline path previously diverged with"v1".ExtractCedarAuthzOptionsdoc comment.