Conversation
jonhealy1
requested changes
Feb 21, 2026
Collaborator
jonhealy1
left a comment
jonhealy1
left a comment
There was a problem hiding this comment.
Looks good. One minor request.
| if gte and value_end < gte: | ||
| return False | ||
| if start_value_begin: | ||
| if lte and start_value_begin > lte < value_begin: |
Collaborator
There was a problem hiding this comment.
Should we change to something like this: if lte and (start_value_begin > lte and value_begin > lte): for better readability.
Collaborator
|
@Gomez324 Some conflicts, from the type hints update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dixed two bugs: application logs were not visible when running via uvicorn due to uvicorn overriding the logging setup, resolved by adding force=True to logging.basicConfig. Additionally, fixed datetime-based index selection that was returning too many indexes when filtering by end_datetime, which could lead to unnecessary indexes being included in search queries.
PR Checklist:
pre-commit run --all-files)make test)