test(runtime): complete terminal cwd store double#8365
Open
beiyonder wants to merge 1 commit into
Open
Conversation
5 tasks
Contributor
📝 WalkthroughWalkthroughThe restored headless mobile tabs test adds a 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the required
getRepomethod to the narrow store double used by terminal startup cwd coverage.Fixes #8363
Screenshots
No visual change.
Testing
pnpm lintpnpm typecheckpnpm test(2,713 files and 28,580 tests passed; 6 files and 40 tests skipped.)pnpm build(not rerun because this changes one test double only.)Verified red-to-green evidence:
origin/mainat3090ff0ed, the focused file reported one failure and three passes withTypeError: this.store?.getRepo is not a function.git diff --checkpasses.AI Review Report
Independent review traced the first bad main commit, checked all production constructor paths, and verified the real store signature. It confirmed this is an incomplete test double, not a production crash. Making the production call optional would weaken the required contract, so the patch remains one test line.
Cross-platform review covered macOS, Linux, Windows, WSL, and SSH. This is test setup only and does not change paths, shells, shortcuts, labels, Git commands, or Electron behavior.
Security Audit
Reviewed whether the failure represented a reachable malformed-store path, input validation gap, auth issue, secret exposure, command execution, dependency, or IPC risk. The only production constructor path passes the real store, whose required
getRepomethod returnsundefinedwhen missing. No runtime or security behavior changes.Notes
store as neverfixture style is existing cleanup and is intentionally out of scope.