Conversation
a43b681 to
4278c1c
Compare
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=====================================
Coverage 79% 79%
=====================================
Files 19 19
Lines 3701 3701
=====================================
Hits 2924 2924
Misses 567 567
Partials 210 210Continue to review full report at Codecov.
|
|
I'd say this functionality is already covered with |
|
I haven't looked at the code, so maybe I'm missing the point, but sql's |
|
AFAIK, modern postgres versions use indices to perform simple counts. This should be quite fast (O(n), but in memory). If I read your code correctly, you perform a query and call This seems good to me. |
|
Now that I maintain this project actively, I'm interested on getting this merged. Please add some documentation and usage examples to |
|
Hey @roobre , unfortunately for kallax I switched to sqlboiler. For now I don't have a time for finishing this, maybe later if it's not urgent. Otherwise example usage is provided in my first comment above, and testing this should be straight-forward, so you can get it merged. |
Example usage: