Open
Conversation
Fix build on Plan 9 and make all tests pass. Note: running `go test ./...` may hang in `TestTempFileMany` or `TestTempFileManyWithUtil`. I'm not sure if it's a go tool issue, standard library issue, or something wrong with the tests. All tests pass if tests are run with `go test -count 1 ./...`. Fixes src-d#52 Signed-off-by: Fazlul Shahriar <fshahriar@gmail.com>
fhs
added a commit
to fhs/go-git
that referenced
this pull request
Dec 25, 2019
Not all the tests pass yet but this makes go-git usable on Plan 9. Please merge this after src-d/go-billy#78. Fixes src-d#756 Signed-off-by: Fazlul Shahriar <fshahriar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix build on Plan 9 and make all tests pass.
Note: running
go test ./...may hang inTestTempFileManyorTestTempFileManyWithUtil. I'm not sure if it's a go tool issue,standard library issue, or something wrong with the tests. All tests
pass if tests are run with
go test -count 1 ./....Fixes #52
Signed-off-by: Fazlul Shahriar fshahriar@gmail.com