Consider convertible argument types in in JDBC query derivation#2249
Closed
wonderfulrosemari wants to merge 2 commits intospring-projects:mainfrom
Closed
Consider convertible argument types in in JDBC query derivation#2249wonderfulrosemari wants to merge 2 commits intospring-projects:mainfrom
wonderfulrosemari wants to merge 2 commits intospring-projects:mainfrom
Conversation
Closes spring-projects#2059 Signed-off-by: wonderfulrosemari <whwlsgur1419@naver.com>
Signed-off-by: wonderfulrosemari <whwlsgur1419@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
changed the title
mp911de
added
type: bug
Member
|
Thank you for your contribution. That's merged, polished, and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2059
Fix query-derivation validation so value objects with registered
Reading/Writing converters are treated as queryable simple properties.
Previously, repository methods like
findAllByRef(CustomerRef ref)could failwith
Cannot query by nested entity: refeven when a custom write target wasconfigured.
Changes include:
passing
JdbcConverterintoJdbcQueryCreator.validate(...)allowing entity-like leaf properties when a custom write target exists
adding regression coverage in
PartTreeJdbcQueryUnitTestsfor converter-backed value objectsadding author headers in touched classes
You have read the Spring Data contribution guidelines.
You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
You submit test cases (unit or integration tests) that back your changes.
You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).