Redirect to referrer instead of root on locale set

[cmrd-senya]

With this change when you change the locale you are redirected to the same page you've been before instead of root of the Rails application.

[cmrd-senya]

We just found out that http referrer is being spoofed on some configuration and can't be used reliably to redirect back. Is it a good idea to use a parameter for the LocaleController#set passing return URL?

[bbonislawski]

Hello @cmrd-senya ,
thanks for your contribution. It's best to use redirect_back method from rails instead of implementing it yourself. Since we support both rails 4.2 and rails 5.x we have to do a little 'hack' like this:

    if Rails.gem_version >= Gem::Version.new('5.x')
      redirect_back(fallback_location: root_path, **params)
    else
      redirect_to :back
    end

Can you try this solution?

[cmrd-senya]

redirect_back uses HTTP_REFERRER too, and the problem with this header is that some web browsers like GNU IceCat spoof this header by default and therefore the feature won't work for users of such browsers. What do you think, if instead (or in addition to) we add a hidden input field with current page location? We can do something like this:

diff --git a/app/views/spree/locale/index.html.erb b/app/views/spree/locale/index.html.erb
index 0dd5e3e..a85b531 100644
--- a/app/views/spree/locale/index.html.erb
+++ b/app/views/spree/locale/index.html.erb
@@ -8,6 +8,12 @@
         <%= select_tag(:switch_to_locale,
           options_for_select(available_locales_options, I18n.locale),
           class: 'form-control') %>
+
+        <%= hidden_field_tag :original_url %>
+        <script>
+          var input = document.getElementById("original_url");
+          input.value = location.href;
+        </script>
         <noscript><%= submit_tag %></noscript>
       </div>
     <% end %>

And then use this input value as a URL to redirect back.

If you're okay with such approach, tell me and I can implement it.