This repository was archived by the owner on Aug 13, 2021. It is now read-only.
wrong super call#150
Open
blset wants to merge 5 commits intospree-contrib:3-1-stablefrom
blset:3-1-stable
Open
wrong super call#150blset wants to merge 5 commits intospree-contrib:3-1-stablefrom blset:3-1-stable
blset wants to merge 5 commits intospree-contrib:3-1-stablefrom
blset:3-1-stable
Conversation
| Deface::Override.new( | ||
| virtual_path: "spree/admin/products/_form", | ||
| name: "multi_domain_admin_product_form_meta", | ||
| :original => '2724f51d519589f73401abeae8f8e05d9dae99c4', |
There was a problem hiding this comment.
@blset Just curious how can I generate this original SHA1 value, from which string?
Author
|
The sha1 is given by deface itself in the log in development mode
the message is something like :
this override has no original consider adding orignal => « the sha1 »
… Le 10 févr. 2017 à 08:43, Paarth ***@***.***> a écrit :
@ParthBarot-BoTreeConsulting commented on this pull request.
In app/overrides/decorate_admin_products_form.rb <#150 (review)>:
> @@ -1,6 +1,7 @@
Deface::Override.new(
virtual_path: "spree/admin/products/_form",
name: "multi_domain_admin_product_form_meta",
+ :original => '2724f51d519589f73401abeae8f8e05d9dae99c4',
@blset <https://github.com/blset> Just curious how can I generate this original SHA1 value, from which string?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#150 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAio_qHd4m8PxHcG8uoDoEYFAx75pUWpks5rbBUHgaJpZM4Iv8Ek>.
|
|
@blset Thanks for your quick reply. So first I should remove the existing Thanks |
Author
|
yes exactly
… Le 10 févr. 2017 à 10:38, Paarth ***@***.***> a écrit :
@blset <https://github.com/blset> Thanks for your quick reply. So first I should remove the existing original (As I am modifying an existing deface in a gem), and then run the server again to see the new sha1 it suggest in the log, and then put that new value in the original attribute. Correct?
Thanks
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#150 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAio_sCs-Y5w0EZzqKYQxN1SV_MCN9gkks5rbDAvgaJpZM4Iv8Ek>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.